Stephen,
First, thanks for the viewpoint, and I agree that API changes should be
well thought out and well planned. But we appear to have very differing
opinions on the need to allow software to evolve.
Stephen Colebourne wrote:
Mark Diggory wrote:
I would initially agree, but Math is still in early development (our
second minor release). I really doubt anyone has created any
alternate implementations of these interfaces that are in any
production env. I think Math is for the time being an implementation,
not a standard. If others were implementing any of our API's I think
we would have found out by now.
Why? How would we know? Users just download the jar, and implement
away. They don't need to talk back to the list. By defining a 1.0
release [math] said 'this is complete' and 'these interfaces will not
change'. If we were talking 0.6 to 0.7 here it wouldn't matter.
And if they do, they should understand that its a new API and subject to
some evolution within constraints outlined in our versioning
specification. 2.0 can and should be allowed to have changes in
interface because its more important to make the improvements requested
from our userbase than to not make a change for the benefit of some
silent party. If your using the API and have a problem with a change,
speak up, we'll be glad to work with you to come to a solution.
So I'll ask again, when is the appropriate time to add methods to an
interface? Seems your suggesting "never". I disagree, I believe that
in our case these modifications can be made and the result will be a
major version release, so I would say these changes go into 2.0,
Again, I stress this point. Commons has many interfaces that we would
like to change after the fact (eg. MultiMap in [collections], or
DynaProperty in [beanutils]). AFAIN, none have been changed even over
a major release version (awaiting someone to prove me wrong...).
Why not over a major version? Major versions are opportunities to fully
break backwards / forwards compatibility and evolve the API. It sounds
sad to me that you guys had opportunities to evolve the Collections API
and didn't take them because you think you'll loose users. I wonder how
many you failed to gain because you didn't make such improvements?
If this were code within a company, then it wouldn't matter. But this
is a publicly available, fully released, API. Open source is sometimes
a pain to work with. This is one of those occasions. And IMHO, all
commons would suffer were the change to happen.
From my perspective, much of commons (and apache in general) is quite
adept at adapting to changes in a package over time.
Did you do any tests to see what in commons was dependent on those
modifications? Did you talk to those specific developers it would appear
to effect and get their viewpoints?
For the record (and in accordance with informing people at the
earliest point possible), I will -1 a 1.x release that changes an
interface. I will -0/-1 a 2.0 release that changes an interface
depening on further discussion. (Bearing in mind that my vote is
non-binding, as a non-math committer)
Yes, I would -1 a 1.x release interface change as well.
I think blocking all interface changes across versions, even major
versions is just too extreme a viewpoint. OS is about building and
evolving "useful" API's. A library full half baked packages because none
were given the leway to evolve isn't very useful at all. In the end you
just end up with allot of users forking the codebase and not
contributing back to the project because no one wants to wait around for
improvements that never get made. So I would wholeheartedly support a
2.x interface change.
-Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]