Eric Pugh <[EMAIL PROTECTED]> writes: >Hi all,
>I checked out 34056 (http://issues.apache.org/bugzilla/show_bug.cgi? >id=34056) and it doesn't seem bad. The one thing Henning highlighted: >- getPrimaryBodyPart().setText(msg, charset); >+// BROKEN! >+// getPrimaryBodyPart().setText(msg, charset); >+ getPrimaryBodyPart().setText(msg); >I don't see why this is "broken"... Seems to me like we add >getPrimaryBodyPart().setText(msg,charset) as well... To add some bikeshed painting: If you make (or just make sure) setText(msg, null) to behave like setText(msg) then the whole conditional can go. Regards Henning -- Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH [EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/ RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire Linux, Java, perl, Solaris -- Consulting, Training, Development 4 - 8 - 15 - 16 - 23 - 42 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
