[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422868 ] Henri Yandell commented on IO-86: ---------------------------------
I like the API - a nice simplification on the Observer pattern stuff I had. I'd rename the FileCleaner example to something else - we already have a FileCleaner and it's got quite the different functionality. Otherwise - +1 to including it. Either make the commit yourself with the fixed <p>'s and FIleCleaner bit, or attach again and I'll happily commit. I'm not sure over the protected methods - are they the right API for the user: * should the big doDirectory method be private * should the event methods all be: handleXxx and not doXxx. * should any other event methods exist - start and end of the whole find? * should we add the cancel() method that somebody asked for in [finder]. Seems easier with this implementation. > Add FileFinder back into Commons IO > ----------------------------------- > > Key: IO-86 > URL: http://issues.apache.org/jira/browse/IO-86 > Project: Commons IO > Issue Type: New Feature > Affects Versions: 1.2 > Reporter: Niall Pemberton > Fix For: 1.3 > > Attachments: FileFinder.java, FileFinderTestCase.java > > > I'd like to propose adding a "FileFinder" back into Commons IO. This is a > simplified version of what was recently moved out of Commons IO into the > "finder" component currently in the sandbox. > I believe this is a simpler, more generic implementation than the finder > component and therefore would be considered suitable for inclusion in Commons > IO. Although simpler it could be used as the basis for achieving the finder > component's aims - namely to emulate the unix find command. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
