[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12422926
]
Niall Pemberton commented on IO-86:
-----------------------------------
I'm happy with the changes you made, except for a couple of minor points wrt to
DirectoryWalker:
1) I think the handleDirectoryEnd() method should be within the "if (process)"
check - so that its not executed if handleDirectoryStart() returns false.
2) How about returning the result List from the handleEnd() method? That would
make it easy if someone wanted to process the results further and return a
different List instance if they required:
protected List handleEnd(List results) {
// do nothing - overridable by subclass
return results;
}
On the issue of whether FileFinder is now needed or not - I agree it adds
minimal value - except as an example DirectoryWalker implementation. I don't
mind if you get rid of it or not.
Niall
> Add FileFinder back into Commons IO
> -----------------------------------
>
> Key: IO-86
> URL: http://issues.apache.org/jira/browse/IO-86
> Project: Commons IO
> Issue Type: New Feature
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Fix For: 1.3
>
> Attachments: FileFinder.java, FileFinderTestCase.java,
> io-filefinder-start-end.patch
>
>
> I'd like to propose adding a "FileFinder" back into Commons IO. This is a
> simplified version of what was recently moved out of Commons IO into the
> "finder" component currently in the sandbox.
> I believe this is a simpler, more generic implementation than the finder
> component and therefore would be considered suitable for inclusion in Commons
> IO. Although simpler it could be used as the basis for achieving the finder
> component's aims - namely to emulate the unix find command.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
