Hi,

There were some methods in OMSourceElementImpl which were merely calling
its super methods. So I removed them. But there was a test written
(OMSourceElementImplTest) to test whether OMSourceElementImpl had
overridden all the methods in OMElementImpl, which is bit unusual in
every sense to me.

1. When a class extends from another class, there is no requirement to
override *all* the methods of the super class.
2. Some methods were just calling the super method.

Dennis (IIRC, you wrote this test), can we please change the test case
and remove those methods from OMSourceElementImpl?

Thanks,
Chinthaka

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to