[ 
https://issues.apache.org/jira/browse/WSCOMMONS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916908#action_12916908
 ] 

Kasun Gajasinghe commented on WSCOMMONS-556:
--------------------------------------------

Andreas,
We thought to use prefixSeparater with the mind of mainly two reasons.
First reason is, quite obvious, it's better to have the separater ":" as a 
variable and then refer to it where the separator should be used. It would make 
the code look clean, and easier to manage instead of hard coded separator ":".

Second reason is, when we analyze the Axis2 profiles, we saw that methods where 
this code line is in use are invoked more than one thousand per request. So, we 
thought that having a instance variable (/class variable if it's the good 
option ) instead of a local variable will probably reduce memory at least a 
little, considering the large number of execution of the code line. This might 
be of little use, as Java already has String literal pool to reuse the same 
string over and over, but with GC comes in place this might be. 

I guess this doesn't break anything, does it? 

--Kasun

> Performance improvement for axiom-dom module
> --------------------------------------------
>
>                 Key: WSCOMMONS-556
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-556
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: AXIOM
>    Affects Versions: Axiom 1.2.9
>         Environment: Java 1.5
>            Reporter: Kasun Gajasinghe
>            Assignee: Nandana Mihindukulasooriya
>         Attachments: axiom-perf-improvement.diff, 
> FINAL-times_for_large_samples_with_changes.png, 
> FINAL-times_for_small_samples_with_changes.png
>
>
> This article published [0] on April 2010, shows that Axis2 has some major 
> performance issues compared to Metro and CXF.  An analysis suggested that 
> most of the problems were with the axiom-dom module's methods, along with 
> Rampart. So, first we went on improving the axiom-dom module. Here's a patch 
> for the improvements we did.
> Final assessments suggest considerable level improvement.  Graphs for a 
> sample run of requests with small and large samples will be added to the 
> files section.
> [0] http://www.ibm.com/developerworks/java/library/j-jws14/index.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to