[
https://issues.apache.org/jira/browse/WSCOMMONS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918474#action_12918474
]
Andreas Veithen commented on WSCOMMONS-556:
-------------------------------------------
I'm not really a fan of introducing constants for single character string
literals that never change, especially if that means modifying a public API
(OMConstants) to add a constant that doesn't respect the usual naming
conventions and that contains a typo...
Speaking about clean, easily manageable code, is there any hard evidence that
replacing
prefix + ":" + localName
by
new StringBuilder(20).append(prefix).append(":").append(localName).toString()
has any impact on performance?
I only see two differences between the two expressions:
* The second one uses a StringBuilder instead of a StringBuffer (because Axiom
is built with a byte code level < 1.5).
* The initial capacity of the StringBuilder/StringBuffer is probably different.
If there is a performance difference due to the usage of StringBuilder, it may
be easier to simply set the byte code level to 1.5 in the Axiom build (we make
use of Java 1.5 APIs anyway, so that is not an issue).
> Performance improvement for axiom-dom module
> --------------------------------------------
>
> Key: WSCOMMONS-556
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-556
> Project: WS-Commons
> Issue Type: Improvement
> Components: AXIOM
> Affects Versions: Axiom 1.2.9
> Environment: Java 1.5
> Reporter: Kasun Gajasinghe
> Assignee: Nandana Mihindukulasooriya
> Attachments: axiom-dom-556-patch2.diff, axiom-perf-improvement.diff,
> FINAL-times_for_large_samples_with_changes.png,
> FINAL-times_for_small_samples_with_changes.png
>
>
> This article published [0] on April 2010, shows that Axis2 has some major
> performance issues compared to Metro and CXF. An analysis suggested that
> most of the problems were with the axiom-dom module's methods, along with
> Rampart. So, first we went on improving the axiom-dom module. Here's a patch
> for the improvements we did.
> Final assessments suggest considerable level improvement. Graphs for a
> sample run of requests with small and large samples will be added to the
> files section.
> [0] http://www.ibm.com/developerworks/java/library/j-jws14/index.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
