Re: [PATCH] *Credentials constructors are sloppy

[Ortwin Gl�ck]

Very much appreciated. Is there a reason for the public setters in this 
class? I would favour immutable Credentials. I see no point in them 
beeing mutable objects, it's not very OO.

Odi

Oleg Kalnichevski wrote:
I think that UserNamePasswordCredentials should not allow null user
name, as well as NTCredentials should not accept null NT domain and
host. Especially NTCredentials in its present form can be too
misleading. One may assume that feeding the constructor with null value
instead of a real domain name will *somehow* make it pick up the actual
Windows domain name, which is of course not the case.
If there are no objections raised by Tuesday next week, I'll commit the
patch as is.
Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]