Patch committed. Setter methods in both classes have been deprecated as suggested by Odi making UserNamePasswordCredentials & NTCredentials objects immutable.
Oleg On Mon, 2003-11-24 at 14:00, Kalnichevski, Oleg wrote: > Odi, > No reason of what so ever. I'll deprecate public setters before committing the patch > to the CVS HEAD. I am not going to change anything for the 2.0 branch > > Oleg > > -----Original Message----- > From: Ortwin Gl�ck [mailto:[EMAIL PROTECTED] > Sent: Monday, November 24, 2003 10:10 > To: Commons HttpClient Project > Subject: Re: [PATCH] *Credentials constructors are sloppy > > > Very much appreciated. Is there a reason for the public setters in this > class? I would favour immutable Credentials. I see no point in them > beeing mutable objects, it's not very OO. > > Odi > > Oleg Kalnichevski wrote: > > I think that UserNamePasswordCredentials should not allow null user > > name, as well as NTCredentials should not accept null NT domain and > > host. Especially NTCredentials in its present form can be too > > misleading. One may assume that feeding the constructor with null value > > instead of a real domain name will *somehow* make it pick up the actual > > Windows domain name, which is of course not the case. > > > > If there are no objections raised by Tuesday next week, I'll commit the > > patch as is. > > > > Oleg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
