From: "Christian Sell" <[EMAIL PROTECTED]> > > I also added an extra test case to show the use of both MyBeanTagLibrary > > which inherits from BeanTagLibrary as well as a test case using MyTagLibrary > > which inherits from TagLibrary which just reuses the BeanTag and > > BeanPropertyTag. i.e. to show that you can reuse this mechanism without > > necessarily deriving from BeanTagLibrary. > > > > hmm. Looking at MyTagLibrary now, I must say that I would always prefer > it the way I did it, i.e. with a registered tag and without using > BeanTagLibrary at all (neither inheriting nor importing classes).
You didn't supply a MyTagLibrary patch. FWIW the MyTagLibrary implementation doesn't use BeanTagLibrary at all. Though there's a MyBeanTagLibrary that shows how BeanTagLibrary can be reused if required. > Also, I dont really see the point in doing it the way you do. Apart from > the rather complex code in MyTagLibrary (>20 lines vs <10 lines before), Though the code in MyTagLibrary could be refactored into a reusable base class. (i.e. BeanTagLibrary but just without the <beandef> tag) > it does not provide additional functionality beyond what can be directly > used (in the script) from BeanTagLibrary. In fact that is what the test > case does - the nested elements are handled through BeanTagLibrary. > > The CustomerTag class is now obsolete, you could delete it. OK. Wanna send me your MyTagLibrary so I can see what you mean? James ------- http://radio.weblogs.com/0112098/ __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
