I have started reviewing code, javadoc and test coverage and I have found a few javadoc errors, some test coverage gaps and a few other odds and ends. Should I submit patches for the tests and javadoc fixes or just apply them? I am happy to help either way.
Here is one code change that I would recommend:
Currently, CollectionUtils.isProperSubCollection(a,b) returns
CollectionUtils.isSubCollection(a,b) && (!(CollectionUtils.isEqualCollection(a,b)));
This is very inefficient, since it is equivalent to
(a.size() < b.size()) && CollectionUtils.isSubCollection(a,b);
There are currently no tests for this method, but the latter works for the ones that I have coded.
So that I can prioritize my efforts, can you provide a list of exactly what is going in 3.0 (or point me to the right thread -- sorry I have not been following Collections too closely).
Phil
Stephen Colebourne wrote:
This is the last call for all [collections] issues, bugs, patches to be raised before [collections] version 3 is created.
I'm currently aiming at a 2-3 week timetable, so you'll have to be quick. If you want to help, checking CVS/nightly build for javadoc issues or other minor issues would be most welcome.
Please note that the main coordination of changes and the release will be on the commons-dev mailing list.
Here's hoping for a successful release real soon...
Stephen
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
