Steve,

Just one very minor comment (see below), everything else looks okay to me.

Paul

Steve Christensen wrote:
> This is a code review request for the update of the SFWslang package to 
> version 2.1.4 and the SFWslrn package to version 0.9.9.   These are connected 
> since slrn depends on the slang version.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/slrnslangwebrev/
> 
> Details:
> 
> 1.  Version numbers and Copyright dates updated where needed.
> 2.  New source files added.  Old ones removed.
> 3.  In the slrn install-sfw file, the new build locations of slrn and 
> slrnpull binaries are changed.
> 4.  Library version numbers updated in slang prototype_com.
> 5.  Two new slrn files added in prototype_com.
> 
> These packages build cleanly in Nevada.  The packages install correctly and 
> produce a working slrn binary.

=== Start of Comments ====

1. src/pkgdefs/SFWslrn/prototype_com
    Copyright year is wrong

=== End of Comments ======

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products

Reply via email to