On Tue, 2007-06-05 at 16:01 +0300, Roi Cohen wrote: > Hi, > > Thanks for putting these changes in git, it indeed makes more sense > than the way I did it first. > I re-made the transparent cube patches to work now with this new interface. > Tell me what you think about it.
0001-cube-painting-order.txt: This is good to go in if you're able to help fix any regressions that may appear. There's some coding style changes that need to be made before I can let this go in, though. Please replace all C++ comments with C comments, keep declarations at the beginning of each scope and make sure lines are no longer than 80 columns. 0002-plugin-events.txt: This is not OK. Plugin events should not be used at all now that 3d and rotate plugins can hook into the cube plugin directly. Just add whatever hooks that are appropriate to the cube plugin. 0003-transparent-cube.txt: Looks OK. The same coding style changes need to be made here too, though. -David _______________________________________________ compiz mailing list compiz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/compiz
