Hi, > > Thanks for putting these changes in git, it indeed makes more sense > > than the way I did it first. > > I re-made the transparent cube patches to work now with this new interface. > > Tell me what you think about it.
I re-did Roi's patches for latest cube plugin changes and coding style. Attached are the following: > 0001-cube-painting-order.txt: > > This is good to go in if you're able to help fix any regressions that > may appear. There's some coding style changes that need to be made > before I can let this go in, though. > > Please replace all C++ comments with C comments, keep declarations at > the beginning of each scope and make sure lines are no longer than 80 > columns. This one is replaced by 0001-Improve-cube-paint-order-calculations.patch. > 0002-plugin-events.txt: > > This is not OK. Plugin events should not be used at all now that 3d and > rotate plugins can hook into the cube plugin directly. Just add whatever > hooks that are appropriate to the cube plugin. Replaced by 0002-Added-rotation-state.patch. With that patch, there is a rotation state variable in CubeScreen that is written by the plugin rotating it, rotate in the current case. > 0003-transparent-cube.txt: > > Looks OK. The same coding style changes need to be made here too, > though. Replaced by 0003-Add-cube-transparency.patch (which adds the cube transparency) and 0004-Added-option-to-enable-cube-transparency-only-on-but.patch (option to enable transparency only on 'manual' rotation). Are these patches ok to go in? Regards, Danny
0001-Improve-cube-paint-order-calculations.patch
Description: application/mbox
0002-Added-rotation-state.patch
Description: application/mbox
0003-Add-cube-transparency.patch
Description: application/mbox
0004-Added-option-to-enable-cube-transparency-only-on-but.patch
Description: application/mbox
_______________________________________________ compiz mailing list compiz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/compiz
