Derick Rethans wrote: > Hallo! > > Related to http://issues.ez.no/IssueView.php?Id=11228 we can address > this in multiple ways: > > 1. Just add this patch to Template/ezcTemplate. > > pro: - very simple > con: - possible to get duplicated code because every component needs > to implement this kind of method itself then. > > 2. Create a new method in File/ezcFile called "isRelativePath". > > pro: - no code duplication > con: - requires Template to depend on the File component. > > 3. Move ezcFile to Base/ezcBaseFile, keeping File/ezcFile as BC class > just extending ezcBaseFile. > > pro: - no code duplication > - no new dependencies > - makes the generic file functions available to all components > con: - makes the File component obsolete > > note: > - the Base and File components needs to be updated in one go > when updating from PEAR (this can however be done with correct > usage of dependencies) > > 4. Create a new class Base/ezcBaseFile that implements the new > isRelative static method. > > pro: - no code duplication > - no new dependencies > con: - makes only this new method available to all components > - two places where we have generic file related functions > > I feel option 3 to be the cleanest, any opinions? If not I'd like to > implement this ASAP - either today or tomorrow.
Do it today. :) -- Alexandru Stanoi eZ Components System Developer eZ Systems | http://ez.no -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
