Andreas Schulz wrote: > Oops, wrong sender mail address - trying again... > > Hi, it's me again - the guy from the sourceforge forum with > the plan to teach the Harmonys Philips Pronto hex codes...
Andreas, Your patch looks very solid. However, your changing things that Stephen's API patch is ALSO going to change (in fact, his patch will make your patch simpler, you won't have to deal with that silly static-size vs dynamic-size thing). Can you wait until his patch is applied and then fix up yours accordingly? Also, in learn_ir_commands, if reading the file fails, you just go into the generic LearnIR code. This is the wrong approach. If the user gave us a file, we should fail if the file wasn't able to be opened. Thanks! -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
