Andreas Schulz wrote: > No problem, it will be a few days anyway before I will have time to dig > into the CVS again - I'll see what's left then...
Cool! Stephen's patch should be merged in the next few days... >> Also, in learn_ir_commands, if reading the file fails, you just go into the >> generic LearnIR code. This is the wrong approach. If the user gave us a >> file, we should fail if the file wasn't able to be opened. > > I just had a look a the patch to verify, but AFAIK that's just what my code > does; it should do (2) only when file_name is null, otherwise if err != 0, > it should proceed from (1) to (3) and just return err (you may have noticed > that I prefer to code single exit points). You're right - I mis-read the patch... ignore my comment. :) -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
