Phil Dibowitz wrote:
>> Didn't see you'd attached a patch. I *really* need to write a "submitting
>> patches" doc.
>>
>> I just read your description, and it sounds pretty spot-on. I'll make a note
>> to look at this as well, though I prefer patches be sent to the list, just
>> FYI.
>
> Looking at your patch, I have a few comments:
>
> 1. It's generated against 0.13, but CVS has changed DRASTICALLY since then -
> can you please re-gen against CVS, and also check our new SubmittingPatches
> file for further details.
>
> 2. It looks like you're right - RESPONSE_DONE should only be received after
> we send COMMAND_STOP_IRCAP, and by reading, we can flush that. Nice catch.
>
> 3. Why do you comment out the 'else if (r == RESPONSE_DONE) {' ? While we
> shouldn't get this in the middle of things, it's certainly bad if we do, and
> a good reason to stop - I'd prefer we leave that check in.
>
> 4. Can you add braces to your outer iff statement for me?
>
> If you could re-submit a patch (to the list, please), with the above
> changes, I'd appreciate it. The idea behind the patch looks solid to me.Andreas, I never saw you re-submit this patch - did I miss it? -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
