On Monday 31 March 2008, Phil Dibowitz wrote:
> Phil Dibowitz wrote:
> > 1. It's generated against 0.13, but CVS has changed DRASTICALLY since
> > then - can you please re-gen against CVS, and also check our new
> > SubmittingPatches file for further details.
done (hopefully conforming the rules now - just left out all the local ?files
from the cvs diff)
> > 3. Why do you comment out the 'else if (r == RESPONSE_DONE) {' ? While we
> > shouldn't get this in the middle of things, it's certainly bad if we do,
> > and a good reason to stop - I'd prefer we leave that check in.
OK - left it in
> > 4. Can you add braces to your outer iff statement for me?
done
> > If you could re-submit a patch (to the list, please), with the above
> > changes, I'd appreciate it. The idea behind the patch looks solid to me.
>
> Andreas,
>
> I never saw you re-submit this patch - did I miss it?
no, you didn't - here it comes...
Index: libconcord/remote.cpp
===================================================================
RCS file: /cvsroot/concordance/concordance/libconcord/remote.cpp,v
retrieving revision 1.26
diff -u -3 -p -u -p -r1.26 remote.cpp
--- libconcord/remote.cpp 30 Mar 2008 23:59:48 -0000 1.26
+++ libconcord/remote.cpp 1 Apr 2008 07:21:26 -0000
@@ -782,6 +782,15 @@ int CRemote::LearnIR(string *learn_strin
const static uint8_t stop_ir_learn[] = { 0x00, COMMAND_STOP_IRCAP };
HID_WriteReport(stop_ir_learn);
+ /* read returned RESPONSE_DONE, otherwise next command wil fail! */
+ uint8_t stop_rsp[68];
+ err = HID_ReadReport(stop_rsp);
+ if (err == 0) {
+ if ((stop_rsp[1] & COMMAND_MASK) != RESPONSE_DONE) {
+ err = 1;
+ }
+ }
+
/*
* Encode our pulses into string
*/
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
