While testing congruity's error handling, I removed my network
connection and found that libconcord's post_*() APIs still returned
success. It turns out that they simply aren't propagating errors
reported by web.cpp. This patch fixes this.
Commit log:
From: Stephen Warren <[EMAIL PROTECTED]>
Fix post_*() APIs to return error codes on failure
Index: Changelog
===================================================================
RCS file: /cvsroot/concordance/concordance/Changelog,v
retrieving revision 1.9
diff -u -p -r1.9 Changelog
--- Changelog 15 Apr 2008 05:45:40 -0000 1.9
+++ Changelog 2 Jul 2008 05:46:09 -0000
@@ -13,6 +13,7 @@ [EMAIL PROTECTED]
[EMAIL PROTECTED]:
- libconcord: README for python bindings
- concordance: Make unistd.h change work for Windows
+- Fix post_*() to return error codes on failure
0.20
Released: 04/13/08
Index: libconcord/libconcord.cpp
===================================================================
RCS file: /cvsroot/concordance/concordance/libconcord/libconcord.cpp,v
retrieving revision 1.35
diff -u -p -r1.35 libconcord.cpp
--- libconcord/libconcord.cpp 14 Apr 2008 07:27:58 -0000 1.35
+++ libconcord/libconcord.cpp 2 Jul 2008 05:46:10 -0000
@@ -703,20 +703,17 @@ int invalidate_flash()
int post_preconfig(uint8_t *data, uint32_t size)
{
- Post(data, size, "POSTOPTIONS", ri, true);
- return 0;
+ return Post(data, size, "POSTOPTIONS", ri, true);
}
int post_postfirmware(uint8_t *data, uint32_t size)
{
- Post(data, size, "COMPLETEPOSTOPTIONS", ri, false);
- return 0;
+ return Post(data, size, "COMPLETEPOSTOPTIONS", ri, false);
}
int post_postconfig(uint8_t *data, uint32_t size)
{
- Post(data, size, "COMPLETEPOSTOPTIONS", ri, true);
- return 0;
+ return Post(data, size, "COMPLETEPOSTOPTIONS", ri, true);
}
int post_connect_test_success(uint8_t *data, uint32_t size)
@@ -736,9 +733,7 @@ int post_connect_test_success(uint8_t *d
add_cookiekeyval = true;
}
- Post(data, size, "POSTOPTIONS", ri, true, add_cookiekeyval);
-
- return 0;
+ return Post(data, size, "POSTOPTIONS", ri, true, add_cookiekeyval);
}
int get_time()
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
