Stephen Warren wrote: > Phil Dibowitz wrote: >> Stephen Warren wrote: >>> While testing congruity's error handling, I removed my network >>> connection and found that libconcord's post_*() APIs still returned >>> success. It turns out that they simply aren't propagating errors >>> reported by web.cpp. This patch fixes this. >> My memory is a little fuzzy here, but I seem to remember this being >> because the Post() function sometimes returned (returns?) spurious >> errors. I seem to remember doing the same thing and then reverting it, >> but it was way early (pre first release) in the development when I had >> more important things to worry about. >> >> That said, this should get merged now. Do me a favor and do a few >> update/fwupdate/etc. runs while connecting to Logitech. If you don't >> havy any problems, we'll merge this, and hopefully any bugs in Post() >> will show up before the next release so we can squash them. > > I just performed 6 update configuration and 3 update firmware runs via > the website, for a total of about 36 post function calls. All worked fine.
Thanks for doing the legwork. I'll queue this for merging (i.e. I can't right now, I gotta head into the office, but it'll get merged the next time I have a moment). -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
