On 01/16/2013 08:35 PM, Scott Talbert wrote: > On Sat, 12 Jan 2013, Scott Talbert wrote: > >> Also, what do you think about moving the pre/post web function calls into >> update_firmware/config()? > > In case you were having trouble visualizing :), the attached is what I was > thinking. I think it makes the API just a little bit cleaner - all of the > functionality related to updating the config or firmware can be done in a > single call.
I don't see the benefit here. They're pretty discreet functions, and while it's common to want to do them together, it's clearly not always the case. Passing these configurations into an API on whether or not to call another API seems more cumbersome than just letting the user call or not call that additional API. > I also rewrote some of the get_stages stuff to be a bit more dynamic, rather > than have a bunch of arrays that are hard coded. LOVE THIS. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
