On Sat, 6 Apr 2013, Phil Dibowitz wrote:

>> OK, here's a patch for sending a "done" when we're done.  The second read is
>> necessary since we don't know the config size at the beginning.
>
> Ugh. I remember this now. That's particularly obnoxious given how big the
> configs are for these guys. It takes a LONG time to dump. Ugh.

Yes it does, but it is only the zwave-hid that is super slow.  I do the 
same thing on usbnet and it reads the whole region much faster.

> Also, this is weird:
>
> Reading config:       100%  1664 KiB   done
> Reading config:       100%  1664 KiB   done
>
> [phil@rider ~]$ ls -lh /tmp/9dump
> -rw-r--r-- 1 root root 457K Apr  6 18:39 /tmp/9dump
>
> That's a pretty big discrepency... :/

The discrepancy is because 1664 KiB is the whole region, whereas 457 KiB 
is the used portion of the region.  Ideally, we would only read the region 
once and only read the portion that is used, but unfortunately a) I don't 
know of a way to get the length of the region without reading the whole 
thing and b) I don't know a way to tell the remote to stop feeding me data 
once it had started sending me data, so I have to read the whole thing. 
Perhaps there is some better way, but I don't know of one, yet.

> Either way your patch works, applying. Though I wonder if we should make that
> one "stage"... so we go 50% for the first read and 99% for the second read or
> something... otherwise it's just confusing to the user.

Eh, I'm inclined to say it is fine for now (this is mostly a power user 
feature), and hopefully we can fix it someday to only read the config 
once.

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to