On Fri, 29 Mar 2013, Phil Dibowitz wrote:
>>> +int CRemoteMH::SetTime(const TRemoteInfo &ri, const THarmonyTime &ht,
>>> + lc_callback cb, void *cb_arg, uint32_t cb_stage)
>>> +{
>>> + return 0;
>>> +}
>>>
>>> Why isn't this LC_ERROR_UNSUPP?
>>
>> I think it was because SetTime() gets called by some of the higher level
>> operations (update config, firwmare) and if it returns non-success, it
>> causes the higher level operations to report failure. I'll add a comment.
>
> Out of curiosity is this a "we don't know how to do it" or a "you don't set
> the time" on these guys?
The Harmony 200/300 do not have displays, so I suppose there really isn't
a reason to set a time on them.
>>> + /* 2nd parameter is the number of packets remaining,
>>> + plus one */
>>> + if (pkts_to_send < 50)
>>> + ack_rsp[7] = pkts_to_send + 1;
>>>
>>> And if it's more than 50? You don't fill it in at all?
>>
>> No, it's initialized to 0x33 before the loop:
>> uint8_t ack_rsp[MH_MAX_PACKET_SIZE] =
>> { 0xFF, 0x03, 0x00, 0x02, 0x01, 0x05, 0x01, 0x33 };
>
> Or rather, if it's > 50, we just leave it at 50?
Yes.
> Man... I feel like we should be able to abstract all of the IR stuff out...
> all the copy-pasta makes me sad.
>
> + // This section lifted from LearnIR() in remote.cpp
> + // Only difference is that MH IR sequence doesn't start at zero.
>
> Can we can just make LearnIRInnerLoop(int seq) and then make both LearnIR
> functions call that one with the right argument?
Yeah, that probably makes sense to do.
> Then minor style thing... I've tried to move all of the assignments to be 'foo
> = bar' instead of 'foo=bar'. A grep shows I have more to do, but can you
> update your for loops? Stuff like:
>
> for (int i=2; i<len+2; i++) {
>
> should be:
>
> for (int i = 2; i < len + 2; i++) {
Yeah, I can do that.
Can we like give ourselves a schedule for getting the next release out?
:-) It seems like it is dragging out forever and it's a pain to have to
get people to patch stuff to test the newer remotes.
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
