On Wed, Apr 3, 2013 at 8:14 AM, Phil Dibowitz <p...@ipom.com> wrote:
> On 04/02/2013 07:56 PM, Scott Talbert wrote:
>>> Do we perhaps want to make this a #define? I realize that debug() is a
>>> #define
>>> that gets compiled out in normal compile and so this becomes an empty
>>> function, which I really hope GCC compiles out, but it may be more clear
>>> what's going on. I don't feel that strongly.
>>
>> Eh, it probably gets compiled out, but even if not, it's probably not a
>> major performance impact.
>>
>>> + /* reset the sequence number to 0 */
>>> + if ((err = HID_WriteReport(msg_six))) {
>>> + debug("Failed to write to remote");
>>> + return LC_ERROR_WRITE;
>>> + }
>>>
>>> Is that really what msg_six does, or is that an errant comment?
>>
>> That's what it does, or at least what I think it does. :)
>
> OK, committed.
>
> At this point it would be great if we could get some testing on as many
> remotes as possible before I prep the release...
>
Correct me if I'm wrong: This is supposed to support the logitech
harmony One? I can test that one and the MyHarmony 300. Anything known
not to work/supposed to work?
--
Bart Cerneels
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
