On Thu, 14 Sept 2023 at 01:43, Po Lu <luang...@yahoo.com> wrote:
>
> Billy Laws <blaw...@gmail.com> writes:
>
> > diff --git a/testsuite/config-sub.data b/testsuite/config-sub.data
> > index ba934b6..aba6ffc 100644
> > --- a/testsuite/config-sub.data
> > +++ b/testsuite/config-sub.data
> > @@ -102,6 +102,8 @@ arm64-apple-tvos                          
> > aarch64-apple-tvos
> >  arm64-apple-tvos10.0.0                               
> > aarch64-apple-tvos10.0.0
> >  arm64-apple-watchos                          aarch64-apple-watchos
> >  arm64-apple-watchos5.0                               
> > aarch64-apple-watchos5.0
> > +arm64ec-w64-mingw32                          arm64ec-w64-mingw32
>
> *-w64-* is not a system vendor, is it?  I presume this ought to be:
I just put what MinGW was using here since that is what I'm targeting, I assumed
that tests should represent what was actually being used.
>
>   arm64ec-pc-mingw64
>
> or something akin to that.
>
> > +arm64ec-windows-msvc                                 
> > arm64ec-unknown-windows-msvc
>
> *-*-windows-* are all misnomers, inasmuch as `msvc' or `gnu'
> (representing MinGW) do not constitute OS names.  The correct operating
> system for MSVC within configuration tuples is `winnt'.
LLVM doesn't even support "winnt" in triples, only "win32" and
"windows".  "-windows-msvc" is
also used throughout its testsuite.

I'll submit a v2 with the test data changed per your suggestions.

Reply via email to