On Tue, Nov 17, 2009 at 10:14:26PM +1030, David Kettler wrote: > If an interactive_error was thrown in a minibuffer completer function, > the error was previously lost. For complicated completers, for > instance when completions are dynamically loaded from a file, it is > useful for the user to see any error messages. This commit ensures > that the error message is displayed briefly in the minibuffer. The > user can continue with typing in the minibuffer as usual. > > The problem arises because direct uses of co_call do not propagate > exceptions. The same fix is applied to the two other places in > conkeror that could lose an error message. One other place, in > download_helper.handle_show, already handled the problem in the same > way. > --- > > An alternative fix would be to provide an interactive_co_call to do > the wrappering. > > The last time I submitted this, Jeremy commented that he had > "specifically intended that an exception being thrown would just > result in no completions being generated." This patch displays an > error, but does not change the user interaction; no completions are > generated and the user is still in the minibuffer read. > > http://thread.gmane.org/gmane.comp.mozilla.conkeror/1522/focus=1524
Can you tell me steps to reproduce the problem, to help me understand the situation being addressed here? -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
