Lots of errors on the console. Can you look into this?
Thanks. I pushed the following fix.
Subject: [PATCH] Properly merge completers with null elements
When a completer does not support an element it was possible for merge
completers to erroneously call the next completer with a negative
index. For instance, this occurred with the wikipedia webjump, for
which the search engine does not provide descriptions for its
completions.
This latent bug was exposed by 2005f2e (Let completion functions set
the match_required state) because more completers can now be on the
completion list, even if they have no results.
---
modules/minibuffer-completion.js | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/modules/minibuffer-completion.js
b/modules/minibuffer-completion.js
index e221bc4..ff453de 100644
--- a/modules/minibuffer-completion.js
+++ b/modules/minibuffer-completion.js
@@ -283,6 +283,8 @@ function merge_completers (completers) {
if (name in r && r[name] != null) {
args.unshift(i);
return r[name].apply(this, args);
+ } else {
+ return null;
}
}
i -= r.count;
_______________________________________________
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror
