On Sat, Feb 18, 2012 at 02:06:21PM -0500, John J. Foerch wrote:
> On Sat, Feb 18, 2012 at 05:12:02PM +0000, Philip Hudson wrote:
> > Inserts the necessary plist XML tags to enable setting Conkeror as
> > the Mac OS X default-browser and for using the darwin command-line
> > 'open' command for URLs (without the '-a conkeror'). The code is
> > simply copied from the wiki, not "mine". Apologies if this is
> > already in a queue somewhere.
> > 
> 
> This patch does not apply cleanly, and further, does not target the named
> feature specifically enough, evidence the duplication of key/value pairs
> that already exist in Info.plist, unfilled information (CFBundleURLName),
> and the apparent random placement of the new hunk near the top of the
> file, ahead of the basic identification of the program.  Now, it's pretty
> clear to me which part of this patch provides the feature in question, but
> as I have no OS X machine available for testing, I must leave it to
> someone else to finish the patch.

There is a comment in our current Info.plist next to CFBundleSignature
where I noted that the value is supposed to be a 4 letter code to
represent the program, but I never understood why this was required, or
whether it had to be unique in some special namespace.. if our OS X
developers could investigate this point, I would appreciate it, and I
would also prefer the code "CNKR" instead of "CONK" (or "conk" as is there
now).  This is because I have made a point over the last few years of
never abbreviating the name of the program, but if we are forced to for a
specific context, my preference is CNKR.

-- 
John Foerch
_______________________________________________
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror

Reply via email to