On Sun, Feb 19, 2012 at 12:18:55PM +0000, Philip Hudson wrote: > On 18 Feb, 2012, at 7:06 pm, John J. Foerch wrote: > > >On Sat, Feb 18, 2012 at 05:12:02PM +0000, Philip Hudson wrote: > >>Inserts the necessary plist XML tags to enable setting Conkeror as > >>the Mac OS X default-browser and for using the darwin command-line > >>'open' command for URLs (without the '-a conkeror'). The code is > >>simply copied from the wiki, not "mine". Apologies if this is > >>already in a queue somewhere. > >> > > > >This patch does not apply cleanly, and further, does not target > >the named > >feature specifically enough, evidence the duplication of key/value > >pairs > >that already exist in Info.plist, unfilled information > >(CFBundleURLName), > >and the apparent random placement of the new hunk near the top of the > >file, ahead of the basic identification of the program. Now, it's > >pretty > >clear to me which part of this patch provides the feature in > >question, but > >as I have no OS X machine available for testing, I must leave it to > >someone else to finish the patch. > > Damn. I should have said: I created the patch as part of my own > update-conkeror script, targeting the *post-install* Info.plist file > generated by xulrunner under /Applications/conkeror.mozdev.org/ > conkeror.app, which is for some reason quite different from > Info.plist in git. > > Let me belatedly explain. Patching git Info.plist is not sufficient. > (I guess that it's necessary, but it's definitely not sufficient.) > The real issue here is that 'xulrunner-bin --install-app' discards > and rearranges parts of the contents of git Info.plist, rendering it > necessary to patch the *deployed* app bundle's Info.plist after > xulrunner has generated it. I hope I'm making myself clear. > > Here's the patch for git Info.plist, taking into account your > preferred 4-byte app code. It happens not to be useful for my > workflow, but I should have submitted it first anyway. Sorry. >
Here is what I still don't understand. If 'xulrunner-bin --install-app' ignores our Info.plist and writes its own, what good does patching our Info.plist do at all? -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
