[
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177157#comment-13177157
]
Karl Wright commented on CONNECTORS-341:
----------------------------------------
bq. I suggest...
Two comments.
First, maybe I didn't understand your use case - I was thinking that you meant
that one might want to write a derived test which set different parameters than
the ones included in the base class. But now you are talking about setting
parameters based on files described by a -D switch? I'm not convinced this is
appropriate.
Second, you can't create two configuration files with one String return value.
:-) Your createConfigFiles() method seems to attempt to do just that.
Another question I have is whether it is ever appropriate to NOT clean up
configuration files when the test is done. Other subsequent tests will lay
down their own configuration files, and in the same folder/directory. Not
cleaning up invites confusion, seems to me.
> override config for test cases
> ------------------------------
>
> Key: CONNECTORS-341
> URL: https://issues.apache.org/jira/browse/CONNECTORS-341
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Tests
> Reporter: Martin Goldhahn
> Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing
> *.Base classes that uses a different config file.
> The config files are actually written in
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden
> localSetup function. each sub-class adds something specific for the test
> case. If I wanted to put something different in the config files I had to
> override localSetup() and copy all content of the superclasses' localSetup to
> it. This can be avoided by moving the code that writes the config file in the
> initialize() method. It makes also more sense in that the creation of the
> config files and the provision of their content are now in the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
