[ 
https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Goldhahn resolved CONNECTORS-341.
----------------------------------------

    Resolution: Not A Problem

I was done testing my changes, but when I wanted to check in the changes I saw 
you had rewritten the whole testing infrastructure. The maven build is also 
broken after the latest update...
Do all test have to sub class a DBMS specific Base class like DerbyBase?
Your understanding of my use case was correct, by the. There is not point in 
taking this issue further, since the whole game has changed.
                
> override config for test cases
> ------------------------------
>
>                 Key: CONNECTORS-341
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-341
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Martin Goldhahn
>         Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing 
> *.Base classes that uses a different config file.
> The config files are actually written in 
> org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden 
> localSetup function. each sub-class adds something specific for the test 
> case. If I wanted to put something different in the config files I had to 
> override localSetup() and copy all content of the superclasses' localSetup to 
> it. This can be avoided by moving the code that writes the config file in the 
> initialize() method. It makes also more sense in that the creation of the 
> config files and the provision of their content are now in the same function.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to