Hi Jussi, On Fri, Oct 08, 2010 at 08:21:15PM +0300, Jussi Kukkonen wrote: > --- > doc/overview-api.txt | 30 ++++++++++++++---------------- > doc/service-api.txt | 14 ++++++++------ > 2 files changed, 22 insertions(+), 22 deletions(-) Looks good overall, thanks for the effort. I just have one monor comment:
> diff --git a/doc/service-api.txt b/doc/service-api.txt > index 4624522..c8f4497 100644 > --- a/doc/service-api.txt > +++ b/doc/service-api.txt > @@ -120,11 +120,13 @@ Properties string State [readonly] > The service state information. > > Valid states are "idle", "failure", "association", > - "configuration" and "ready". > + "configuration", "ready" and "online". > > - Also "login" and "online" states are used. The > - state "online" signals that an Internet connection > - is available and has been verified. > + The "ready" state signals a successfully > + connected device. This doesn't mean it has the > + default route, but basic IP operations will The default route attribution is almost orthogonal to the service state, so I find the default route mention here a bit confusing. Could you please remove that statement ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
