On 10/24/2010 05:08 PM, Marcel Holtmann wrote: > Hi Kalle, Hi Marcel,
>> - dbus_message_set_auto_start(message, FALSE); >> - >> dbus_message_append_args(message, DBUS_TYPE_STRING, &interface, NULL); > > this patch is wrong. The non-autostart stuff is there on purpose. We do > want control when the daemon is started. And more important in case of > crash situation to be able to clean this properly. I was thinking that there's likely a reason like that. >> + supplicant_dbus_property_get_all(SUPPLICANT_PATH, >> SUPPLICANT_INTERFACE, >> service_property, NULL); >> - > > I actually prefer to autostart a daemon by asking for the introspection > data and not via an actual method call. Just a quick hint here. That sounds good to me. Thank you for the review. Mohamed, do you want to create a patch or should I do it? Kalle _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
