Hi Leena,

> Hi Marcel,
> 
> Below is the modified patch based on your comments.

if you do thinks like this then when I use git am, I see Hi Marcel in
the commit message. We don't really wanna have that ;)

> ------
>  gsupplicant/supplicant.c |   20 +++++++++++++++++++-
>  1 files changed, 19 insertions(+), 1 deletions(-)
> 
> diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
> index 322b63d..9472fe2 100644
> --- a/gsupplicant/supplicant.c
> +++ b/gsupplicant/supplicant.c
> @@ -2387,6 +2387,23 @@ static const char *g_supplicant_rule5 = "type=signal,"
>  static const char *g_supplicant_rule6 = "type=signal,"
>                       "interface=" SUPPLICANT_INTERFACE ".Interface.Blob";
>  
> +static void invoke_introspect_method()

it is _method(void) if it has no arguments. If you would
use ./bootstrap-configure and enable maintainer mode and have our strict
compiler warnings it should show up there.

> +{
> +     DBusMessage *message;
> +
> +     message = dbus_message_new_method_call(SUPPLICANT_SERVICE,
> +                                     SUPPLICANT_PATH,
> +                                     DBUS_INTERFACE_INTROSPECTABLE,
> +                                     "Introspect");
> +
> +     if (message == NULL)
> +             return;
> +
> +     dbus_message_set_no_reply(message, TRUE);
> +     dbus_connection_send(connection, message, NULL);
> +     dbus_message_unref(message);
> +}
> +
>  int g_supplicant_register(const GSupplicantCallbacks *callbacks)
>  {
>       connection = dbus_bus_get(DBUS_BUS_SYSTEM, NULL);
> @@ -2426,7 +2443,8 @@ int g_supplicant_register(const GSupplicantCallbacks 
> *callbacks)
>               supplicant_dbus_property_get_all(SUPPLICANT_PATH,
>                                               SUPPLICANT_INTERFACE,
>                                               service_property, NULL);
> -     }
> +     } else
> +             invoke_introspect_method();

I would not have called it invoke_introspect_method actually, but this
is just fine as well.

Regards

Marcel


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to