Hi Sameo, Had few doubts about the offlinemode issue.
When offlinemode is ON and the device is enabled, the device is powered ON and offlinemode is set to FALSE. Now if user does a `test-connman offlinemode` it will show that offlinemode is OFF. This gives an impression that on enabling the device, the offlinemode is automatically set to OFF. And hence on reboot user would expect that offlinemode is OFF. So I guess we should set the device->offlinemode to false but should not invoke __connman_profile_set_offlinemode(). With this `test-connman offlinemode` will still display ON. Or maybe we should provide some indication to the user that on enabling the device in offlinemode, the offlinemode will temporarily be set to OFF. I might be wrong in understanding this but request you to clarify my doubts. Also there is another issue related to offlinemode value when rfkill a wifi device: http://bugs.meego.com/show_bug.cgi?id=9082 Which I have evaluated as not a bug. Could you provide your inputs on this one as well? Thanks, Leena -----Original Message----- From: Samuel Ortiz [mailto:[email protected]] Sent: Tue 11/2/2010 8:35 PM To: Leena S Gunda (WT01 - Innovation Group) Cc: [email protected] Subject: Re: [PATCH] Save offlinemode when device enabled Hi Leena, On Fri, Oct 29, 2010 at 07:22:36PM +0530, [email protected] wrote: > Below is a patch for: > > http://bugs.meego.com/show_bug.cgi?id=8747 > http://bugs.meego.com/show_bug.cgi?id=8866 > > When offlinemode is on and device is enabled using enable-device test script, > the Powered property is set to true. The device set_property sets > powered_persistent to TRUE and writes this to the active profile. The device > is then enabled and offlinemode is set to FALSE. But this data is not written > to the active profile. > > In __connman_device_enable() after setting offlinmode to FALSE, if > powered_persistent is TRUE then saving the profile will fix this issue. > Although your patch certainly fixes those 2 bugs, I am not going to apply it since the bugs are actually invalid. Offline mode can only be permanently switched when the user or an application explicitely set it (through Manager.SetProperty). When a technology is enabled while in offline mode, ConnMan only temporarily goes to online mode. I have closed those 2 bugs now, I hope you didnt waste too much time on this. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ Please do not print this email unless it is absolutely necessary. The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
