Hi Guillaume, On Mon, Apr 18, 2011 at 03:56:16PM +0200, Guillaume Zajac wrote: > From: Gustavo F. Padovan <[email protected]> > > --- > src/manager.c | 3 ++- > src/tethering.c | 55 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 56 insertions(+), 2 deletions(-) > > diff --git a/src/manager.c b/src/manager.c > index f73330c..06a66b3 100644 > --- a/src/manager.c > +++ b/src/manager.c > @@ -649,7 +649,8 @@ static GDBusMethodTable manager_methods[] = { > { "UnregisterCounter", "o", "", unregister_counter }, > { "CreateSession", "a{sv}o", "o", create_session }, > { "DestroySession", "o", "", destroy_session }, > - { "RequestPrivateNetwork", "", "h", request_private_network, > + { "RequestPrivateNetwork", "", "hssss", > + request_private_network, The IP settings should be a dictionary as it is a lot cleaner for the requester to parse it back. Also, that should be documented, and I don't see any doc/manager-api.txt changes in your patchset. Look at Gustavo's initial patches, they had a patch for it.
Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
