On 04/19/2011 10:47 AM, Samuel Ortiz wrote: > Hi Guillaume, > > On Mon, Apr 18, 2011 at 03:56:15PM +0200, Guillaume Zajac wrote: >> --- >> include/inet.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/include/inet.h b/include/inet.h >> index 9a9411d..19f4455 100644 >> --- a/include/inet.h >> +++ b/include/inet.h >> @@ -75,6 +75,7 @@ int connman_inet_remove_from_bridge(int index, const char >> *bridge); >> >> int connman_inet_set_mtu(int index, int mtu); >> int connman_inet_setup_tunnel(char *tunnel, int mtu); >> +int connman_inet_create_tunnel(char **iface); > That should be included with the previous patch. I haven't tried, but I'm > quite sure the build breaks if you don't apply this patch and the following > one. > > I understand you want (and deserve) to get credits for your work here. I > suggest you keep Gustavo's patch for the TUN interface creation, and then add > yours on top of it that does that: Moving this API to inet.c and fixing the > callers.
BTW, I think connman_inet_*_tunnel should be reused at one point for plugins/vpn.c. cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
