Hi Tomasz, > Here the first shoot of wispr support patches. So please review. > > It removes location stuff, and merges portal and wispr in one place. Portal > code works fine in such merge. > > I just tested wispr and apparently it works. I say "apparently" because the > last step of wispr processi (https post request) can't be done due to a gweb > bug around gnutls. > I will fix that after, but it sounded anyway the right time to present these > patches, since the last step in wispr is trivial, so I suppose it should work. > > About wpad: I added the wispr logic entry there, but I am going to prepare > some patch for fixing wpad too since currently wpad is not able to work for > both ipv4 and ipv6 in separated context. > > Cheers, > > Tomasz Bursztyka (7): > location: deleted location support and portal plugin. > tools: removing standalone wispr tool. > wispr: merged location/portal and wispr support in one place. > wispr: agent api logic added. > wispr: adding wispr logic entries in service and wpad. > test: added wispr username/password request input handlers in > simple-agent. > todo: removed wispr task. > > Makefile.am | 11 +- > Makefile.plugins | 12 - > TODO | 10 - > configure.ac | 6 - > include/location.h | 78 ------ > include/wispr.h | 48 ++++ > plugins/portal.c | 239 ----------------- > src/agent.c | 132 ++++++++++- > src/connman.h | 22 +- > src/location.c | 294 --------------------- > src/main.c | 2 - > src/service.c | 23 +-- > src/wispr.c | 722 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > src/wpad.c | 6 + > test/simple-agent | 61 ++++- > tools/wispr.c | 709 --------------------------------------------------- > 16 files changed, 980 insertions(+), 1395 deletions(-) > delete mode 100644 include/location.h > create mode 100644 include/wispr.h
I have not looked at the code, but why do we need a public header. Public headers should only be used for things that we wanna export to plugins. Everything else needs to kept local and exported in connman.h include file. > delete mode 100644 plugins/portal.c > delete mode 100644 src/location.c > delete mode 100644 tools/wispr.c Please do not delete tools/wispr.c since that will be still a very good testing tool for various people. I wanna keep that around. Regards Marcel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
