Hi Tomasz,
<snip>
> +#ifndef __CONNMAN_WISPR_PORTAL_H
> +#define __CONNMAN_WISPR_PORTAL_H
> +
> +#include <connman/service.h>
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/**
> + * SECTION:wispr_portal
> + * @title: Wispr_Portal primitives
> + * @short_description: Functions for detecting wispr_portals
> + */
> +
> +enum connman_wispr_result {
> + CONNMAN_WISPR_RESULT_UNKNOWN = 0,
> + CONNMAN_WISPR_RESULT_LOGIN = 1,
> + CONNMAN_WISPR_RESULT_ONLINE = 2,
> + CONNMAN_WISPR_RESULT_FAILED = 3,
> +};
so I had time to look at this now. And these should be clearly internal.
We should have a proper internal struct connman_service API to report
results etc.
And of course once WISPr login page is present or out ConnMan server
returned location details, we should report these back as well.
Initially I like to see the WISPr support just make the HTTP request and
report the result. Parsing of the XML etc. should be added by follow up
patches. So that we have a chance to review this step by step.
Regards
Marcel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
