Hi Alok, On Thu, Jun 30, 2011 at 03:25:38PM +0300, Alok Barsode wrote: > From: Alok Barsode <[email protected]> > > Add the pending dbus message per technology. Also move the pending > timeout from manager to technology. The code looks good, but you have several lines of code that are over 80 chars. Moreover, some additional comments:
> @@ -720,15 +761,33 @@ int __connman_technology_enable(enum > connman_service_type type) > err = __connman_device_enable(device); > /* > * err = 0 : Device was enabled right away. > - * err = -EINPROGRESS : DBus call was successful. > * If atleast one device gets enabled, we consider > * the technology to be enabled. > */ > - if (err == 0 || err == -EINPROGRESS) > + if (err == 0) > ret = 0; Just return 0 here, and get rid of the ret variable. Ditto for technology_disable(). Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
