Hi Jukka,
Some nitpicks:
On Wed, Jul 27, 2011 at 03:49:35PM +0300, Jukka Rissanen wrote:
> @@ -1327,7 +1334,18 @@ int g_dhcp_client_start(GDHCPClient *dhcp_client)
> dhcp_client->xid = rand();
> }
>
> - send_discover(dhcp_client, 0);
> + if (last_address == NULL)
> + addr = 0;
For highly arguable aestethic reasons, I'd prefer to see a symetric bloc
opening with the if, even though it will contain only addr = 0.
> + else {
> + addr = inet_addr(last_address);
> + if (addr == 0xFFFFFFFF)
> + addr = 0;
Ditto.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
