Hi Jukka,
On Wed, Jul 27, 2011 at 03:49:34PM +0300, Jukka Rissanen wrote:
> diff --git a/src/ipconfig.c b/src/ipconfig.c
> index 9f73b65..7fb56a4 100644
> --- a/src/ipconfig.c
> +++ b/src/ipconfig.c
> @@ -54,6 +54,7 @@ struct connman_ipconfig {
> struct connman_ipaddress *system;
>
> int ipv6_privacy_config;
> + char *last_dynamic_ip_address;
We could even call this one last_dhcp_address.
> +char *__connman_ipconfig_get_dhcp_address(struct connman_ipconfig *ipconfig)
> +{
> + if (ipconfig == NULL)
> + return NULL;
> +
> + return g_strdup(ipconfig->last_dynamic_ip_address);
Do we really need to duplicate the string here ? Code calling this API will
not run when an ipconfig is not set anyway.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
