Hi,
On Mon, Aug 29, 2011 at 10:48 AM, Yu A Wang <[email protected]> wrote:
> If user forget to turnoff offlinmode, all device will be always offline
> after restart connmand or reboot, it may confuse the user.
> ---
> src/technology.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/technology.c b/src/technology.c
> index 96d64af..a067d68 100644
> --- a/src/technology.c
> +++ b/src/technology.c
> @@ -395,7 +395,7 @@ static connman_bool_t
> connman_technology_load_offlinemode()
> offlinemode = g_key_file_get_boolean(keyfile, "global",
> "OfflineMode", &error);
> if (error != NULL) {
> - offlinemode = TRUE;
> + offlinemode = FALSE;
> g_clear_error(&error);
> }
> __connman_storage_close_profile("default", keyfile, FALSE);
>
IMO If the user forgot to turnoff offlinemode, then the device should start
in offlinemode.
This patch is wrong because it sets offlinemode to OFF when there is a error
in reading the default vaule.
If Samuel or Marcel agree that a device should start in normal mode
irrespective of the state before switch off, then u need to make the
global_offlinemode default value to TRUE.
Cheers,
Alok.
> --
> 1.7.2.2
>
> _______________________________________________
> connman mailing list
> [email protected]
> http://lists.connman.net/listinfo/connman
>
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
