Hi Alok, >-----Original Message----- >From: [email protected] >[mailto:[email protected]] On Behalf Of alok barsode >Sent: Monday, August 29, 2011 4:07 PM >To: [email protected] >Subject: Re: [PATCH 1/3] technology: Set default offlinemode as FALSE > >Hi, > >On Mon, Aug 29, 2011 at 10:48 AM, Yu A Wang <[email protected]> wrote: > >> If user forget to turnoff offlinmode, all device will be always offline >> after restart connmand or reboot, it may confuse the user. >> --- >> src/technology.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/technology.c b/src/technology.c >> index 96d64af..a067d68 100644 >> --- a/src/technology.c >> +++ b/src/technology.c >> @@ -395,7 +395,7 @@ static connman_bool_t >> connman_technology_load_offlinemode() >> offlinemode = g_key_file_get_boolean(keyfile, "global", >> "OfflineMode", >&error); >> if (error != NULL) { >> - offlinemode = TRUE; >> + offlinemode = FALSE; >> g_clear_error(&error); >> } >> __connman_storage_close_profile("default", keyfile, FALSE); >> > >IMO If the user forgot to turnoff offlinemode, then the device should start >in offlinemode. > >This patch is wrong because it sets offlinemode to OFF when there is a error >in reading the default vaule. Yes, you may right, but think a situation, when a user first use connman, there will be no default.profile in /var/lib/connman, then when we load offlinemode or load_state, there will be always failed, then the offlinemode is ON, also all technology will in offline state. When the user enable wifi and everything works well, but forget to turnoff offlinemode, after reboot, all technology will in offlinemode again :(, I just thought it may not user friendly.
Thanks Arron
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
