From: Patrik Flykt <[email protected]>
Hi,
Here's a patch implementing ServicesChanged signal while removing ServicesAdded
and ServicesRemoved signals.
If we allow service properties to alwas be empty when the service is changed,
the new signal can be considered implemented. If we want to send the updated
properties as well, there will be a need to add quite some amount of update
flags into the service structure. Also, ServicesChanged signal will be
sent whenever the service sequence is sorted. Unfortunately the sequence
sorting function does not tell whether the ordering got changed. With the
current implementation ConnMan wil thus send ServicesChanged also if the
order really did not change. Fixing this would again add some extra code,
I don't know how "perfect" behavior we want for this case.
For new services, all properties will be sent like previously with the
ServicesAdded signal.
Please review,
Patrik
Patrik Flykt (2):
service: Add ServicesChanged signal
service: Schedule ServicesChanged signal to be sent
src/manager.c | 3 +-
src/service.c | 112 ++++++++++++++++++++++++++-------------------------------
2 files changed, 52 insertions(+), 63 deletions(-)
--
1.7.9.1
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
