On Tue, Oct 2, 2012 at 12:02 PM, Daniel Wagner <[email protected]> wrote: > From: Daniel Wagner <[email protected]> > > --- > doc/coding-style.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/doc/coding-style.txt b/doc/coding-style.txt > index 30690b7..b5ef30e 100644 > --- a/doc/coding-style.txt > +++ b/doc/coding-style.txt > @@ -306,6 +306,15 @@ Example: > 2) > 0x1 << y // Wrong > > +M17: Always explicitly initialize static variables > +================================================== > +Any static declared value need to be assign the initial value. > + > +Exmaple: > + > +static GHastTable *driver_hash = NULL; > +static int owner_watch = 0; > +
This is ugly and doesn't really help readability IMO. Looking at the current source code and of similar projects (oFono/BlueZ) we have a mixed use of these. > O1: Shorten the name > ==================== > Better to use abbreviation, rather than full name, to name a variable, > -- > 1.8.0.rc0 already testing new stuff? :) Lucas De Marchi _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
