On tis, 2012-10-02 at 17:02 +0200, Daniel Wagner wrote:
> +M17: Always explicitly initialize static variables
> +==================================================
> +Any static declared value need to be assign the initial value.
> +
> +Exmaple:
> +
> +static GHastTable *driver_hash = NULL;
> +static int owner_watch = 0;
It is true that ConnMan is inconsistent in initializing static
variables, but I don't see any readability benefits from explicit
initializations either. So why not leave it in the state it is right
now, and for new or fixed code do the initialization whenever it helps
code readability and understanding?
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
