Hi Denis, On Sun, Dec 30, 2012 at 05:36:30AM -0600, Denis Kenzior wrote: > On 01/02/2013 09:32 AM, Daniel Wagner wrote: > >Hi Forest, > > > >On 28.12.2012 20:22, Forest Bond wrote: > >>From: Forest Bond<[email protected]> > >> > >>Previously, the CDMA device was created only after the CDMA > >>ConnectionManager interface was added. This created a chicken-and-egg > >>problem because oFono would not add the CM interface until after the > >>modem was online, but we would not set the modem online until enabling > >>the device (which was not created yet). As a result, CDMA modems would > >>only work if they were set online manually. > > > >So what you are saying is that the comment in ready_to_create_device() > >is wrong, > > > > /* > > * There are three different modem types which behave slightly > > * different: > > * - GSM modems will expose the SIM interface then the > > * CM interface. > > * - CDMA modems will expose CM first and sometime later > > * a unique serial number. > > * > > * This functions tests if we have the necessary information gathered > > * before we are able to create a device. > > */ > > > >I remember discussing this back and forth with Denis and IIRC the comment > >here is correct. > > > >Denis, can you confirm? > > > > So here is what I think happened. The logic above and the comment > was/is correct when the modem driver does not implement the .online > method. For example, plugins/nokiacdma.c and plugins/speedupcdma.c. > When the .online method is missing (e.g. NULL), oFono core > automatically transitions the device into Online state. > > At some point this was broken when the Huawei CDMA and GSM plugins > were merged and is likely only broken for these devices. Guess > nobody ever regression tested / cared about this :) > > Regards, > -Denis
I'd like to pick this back up. Can you offer some input regarding the best way to fix things? Thanks, Forest -- Forest Bond http://www.alittletooquiet.net http://www.rapidrollout.com _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
