Hi Daniel,

just a minor notice about the error prints in the code.

+       connman_warn("Failed to install iptables rules: %s", strerror(-err));
+

What about adding also the value of -err to the print?

The error code is printed in many places in other parts of connman code and sometimes it is useful when figuring out what the actual error is (no need to map the string back to number).


Cheers,
Jukka


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to